my comment is wrong, exec handles BSS fine

05d66b06 · Robert Morris · 4587b358 · 05d66b06 · 05d66b06
--- a/exec.c
+++ b/exec.c
@@ -48,9 +48,6 @@ exec(char *path, char **argv)
  }
  iunlockput(ip);

-  // XXX rtm: what about the BSS? shouldn't there be some
-  // bzero()ing here?
-
  // Allocate and initialize stack at sz
  sz = spbottom = PGROUNDUP(sz);
  if(!(sz = allocuvm(pgdir, sz, sz + PGSIZE)))

--- a/usertests.c
+++ b/usertests.c
@@ -1419,6 +1419,21 @@ validatetest(void)
  printf(stdout, "validate ok\n");
 }

+char uninit[10000];
+void
+bsstest(void)
+{
+  int i;
+  printf(stdout, "bss test\n");
+  for(i = 0; i < sizeof(uninit); i++){
+    if(uninit[i] != '\0'){
+      printf(stdout, "bss test failed\n");
+      exit();
+    }
+  }
+  printf(stdout, "bss test ok\n");
+}
+
 int
 main(int argc, char *argv[])
 {
@@ -1430,6 +1445,7 @@ main(int argc, char *argv[])
  }
  close(open("usertests.ran", O_CREATE));

+  bsstest();
  sbrktest();
  validatetest();