use asm() for lock release, not a C assignment

34c2efc1 · Robert Morris · d63ac118 · 34c2efc1
--- a/spinlock.c
+++ b/spinlock.c
@@ -59,8 +59,10 @@ release(struct spinlock *lk)
  // stores; __sync_synchronize() tells them both to not re-order.
  __sync_synchronize();
-  // Release the lock.
+  // Release the lock, equivalent to lk->locked = 0.
-  lk->locked = 0;
+  // This code can't use a C assignment, since it might
+  // not be atomic.
+  asm volatile("movl $0, %0" : "+m" (lk->locked) : );
  popcli();
 }