提交 f8ac6396 创建 作者: kaashoek's avatar kaashoek

a few other nits

上级 b438eff6
missing bootmain.c from printout runoff.list:
funny \ alignment in mmu.h bootmain.c missing
mmu.h:
funny \ alignment in mmu.h
main.c: main.c:
should use static int bcpu to avoid having live should use static int bcpu to avoid having live
stack variable across the asm volatile that stack variable across the asm volatile that
changes %esp and %ebp. changes %esp and %ebp.
cpus[0] -> cpus[bcpu]
init.c: init.c:
should while(wait() >= 0); should while(wait() >= 0);
not just wait(); not just wait();
...@@ -30,7 +35,12 @@ proc.c: ...@@ -30,7 +35,12 @@ proc.c:
proc_exit should wake up proc[1] if any proc_exit should wake up proc[1] if any
reparenting was done. reparenting was done.
sched -> switch2scheduler? or just switch?
trap.c trap.c
if spin locks are ever held without cli, if spin locks are ever held without cli,
trap should call yield() only if nlock == 0 trap should call yield() only if nlock == 0
main.c, proc.c, trap.c:
use a constant for 3 (USER).
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论